[DRAFT] Py Adapter with NodeVisitor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from os import environ | ||
| class PythonAdapterFactory: | ||
| PY_ADAPTER_LATEST_ENV_VAR = "PY_ADAPTER_LATEST" |
There was a problem hiding this comment.
The design is very good. The point is that we do no need anymore the old quick and dirty implementation I had done, or do you see any reason to still keep it?
| def visit_AnnAssign(self, node: AnnAssign) -> Any: | ||
| static_name: str = node.target.id | ||
| static_type: str = CommonInfrastructure.NOT_EXTRACTED | ||
| if isinstance(node.annotation, ast.Name): |
There was a problem hiding this comment.
I was wondering whether moving check of name in a specific leave of the tree would make sense. What do you think?
| # Instance and method vars | ||
| method: Datastructure.Method = sub_datastructure.get_method(self.active_method_name_list[-1]) | ||
| target = node.target | ||
| if isinstance(target, ast.Attribute) or isinstance(target, ast.Name): |
There was a problem hiding this comment.
I was wondering whether moving the check of attribute to a specific leave of the tree would make sense. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.