-
Notifications
You must be signed in to change notification settings - Fork 111
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AXS-9: add a new section to app exchange to connect cluster to market…
…place (#1000) * add marketplace connector to appstore remove active from app-filters when clicking on launch market remove padding from makret-content move launch market to bottom cluster enabled, link and settings use real api fix icon i18n fix i18n set api_url if it is empty on enable and link confirm dangerous actions fix * fix var name in template * use grey instead of yellow * show cluster id * add link to marketplace * open in new tab * i18n for go to marketplace * add cluster name to cluster link page * Apply suggestions from code review Co-authored-by: Joris Tirado <[email protected]> * use camelCase in i18n file * nest scss rules to clarify + convert rgb color to hex * use base colors, move css styles out of html * use camelCase in i18n * move string to i18n file * using getStore/setStore instead of polluting the app namespace * use insertTemplate * move maybeSetApiUrl to its own method * fix cluser_id in template * use base color * getStore/setStore are defined by default in app namespace * call callback only if there is no error? * self is the new this * revert storing appstoreData in store, store marketConfig instead Revert all changes related to appstoreData, so it behaves as before. Instead switching to fetch marketConfig data on demand when clicking on marketConnector button, since I leanred how to store data in app namespace without needing passing around the marketConfig object. This also fixes fake mock. Also fixing setting marketConfig after updateMarketConnector instead of mutating appstoreData.marketplace as before. * no detach, move renderApplist and its binding events to its own function To fix issues with fadeIn/fadeOut and searchInput, instead of using detach to switch between marketplce connector and app list, we just call renderApplist again. By moving all app list view binding events to its own function then we successfully fix the issue with search input too. Now when you switch back to app list from marketplace view the search input now works. Co-authored-by: Joris Tirado <[email protected]>
- Loading branch information
1 parent
d0da983
commit fb40f70
Showing
10 changed files
with
817 additions
and
62 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.