-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check HTTPS_ENABLED env var before HTTPS redirection #7
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…r, to website container
I added an extra file https://github.com/2004Scape/Website/pull/7/files#diff-51f6929abdfb9361c8f1466cd14634dbb7f67c2a8eb5de79aa8ff9e61c46df5a This doesn't change anything with how worlds work, its only to make docker production build easier (I'll add clear instructions for this in #1074) |
Looks good. Note: world config will be moved to the database in one of the next feature updates so this may need to be touched on again then. |
Description
Uses HTTPS_ENABLED environment var for HTTPS redirection
Adds world config loader for docker
Users can now configure worlds directly from server repo, when running prod build
Environment variable is now passed to all 23 routes which use the header.ejs:
ᴄʟɪᴄᴋ ғᴏʀ ᴅᴇᴛᴀɪʟs
Why
For production build to work, these changes need to be made in the Website repository, as docker is pulling it from Server, see #1074