fix: Secondary Pointers. HuntMode Packing. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pazaz
requested changes
Nov 28, 2023
| @@ -208,8 +209,56 @@ export function parseNpcConfig(key: string, value: string): ConfigValue | null | | |||
| return null; | |||
| } | |||
| } else if (key === 'huntmode') { | |||
| // TODO | |||
| return value; | |||
| switch (value) { | |||
There was a problem hiding this comment.
This should be PACKFILE.get('hunt')!.indexOf(value) and return null if it's -1
Pazaz
reviewed
Nov 28, 2023
| throw new Error('unimplemented'); | ||
| const mode = state.popInt(); | ||
|
|
||
| if (mode === -1 || mode > HuntMode.BIGMONSTER_MELEE) { |
There was a problem hiding this comment.
Meant to include this in the review. Hunt lookups should go to the HuntType, and if the compiler needs to be aware of it then we just have to generate hunt.tsv values for the compiler (if it's not already)
Pazaz
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xes.