Feature/nft drop/cli refactoring #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create dir before file save
…e/nft_drop/sol/interface
2. Enable passing the NFT ID to account mapping via a file.
3. fix metadata file name format to ${version}-ntf-drop.json
4. make flagSaveLink enabled by default
5. provide readme, install nft_drop as a yarn package to simplify running
6. clean more output dirs in clean mode (and not not error-prone anymore)
…d->account. NFTMerkleDrop.sol - adapt to new format. generation script nft_drop.js supports both formats now (old and new), both from file and cli params (parseMapping adapted). add parseMapping tests; nft_drop.js now runs generation if only called directly (not to run during test parseMapping)
…ment, add MyERC721Token.sol for tests. auto-increment generation version if passed as null; add NFTMerkleDrop.test.js (under construction)
… still reverted on claim
…ipientSigner to fix ERC721IncorrectOwner. fix NFTMerkleDrop.sol
move nft drop arguments parsing to function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.