Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1052] rawETH flag on withdrawal #12

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

byshape
Copy link
Contributor

@byshape byshape commented Jan 30, 2024

Added ability to withdraw native currency for the maker.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52b783b) 76.84% compared to head (cefe838) 78.64%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           SC-1039-Optimize-cross-chain      #12      +/-   ##
================================================================
+ Coverage                         76.84%   78.64%   +1.79%     
================================================================
  Files                                 4        4              
  Lines                                95      103       +8     
  Branches                             17       21       +4     
================================================================
+ Hits                                 73       81       +8     
  Misses                               22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zZoMROT
Copy link
Contributor

zZoMROT commented Feb 1, 2024

It might be worth considering extracting a method similar to isETH, perhaps something like isNative, to make the code more readable. Just a suggestion, as I'm not entirely sure if it's necessary or it's make code more readable

Base automatically changed from SC-1039-Optimize-cross-chain to master February 8, 2024 08:55
@ZumZoom ZumZoom merged commit cd550bd into master Feb 8, 2024
5 checks passed
@ZumZoom ZumZoom deleted the SC-1052-rawETH-flag-on-withdrawal branch February 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants