Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access token modifier to public withdraw or cancel functions #105

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

byshape
Copy link
Contributor

@byshape byshape commented Aug 16, 2024

No description provided.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (7b8d3f7) to head (f909715).
Report is 5 commits behind head on master.

Files Patch % Lines
contracts/EscrowFactory.sol 0.00% 2 Missing ⚠️
contracts/zkSync/EscrowFactoryZkSync.sol 0.00% 2 Missing ⚠️
contracts/BaseEscrow.sol 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   64.28%   59.86%   -4.42%     
==========================================
  Files          16       16              
  Lines         154      152       -2     
  Branches       22       21       -1     
==========================================
- Hits           99       91       -8     
- Misses         54       61       +7     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/BaseEscrow.sol Outdated Show resolved Hide resolved
test/utils/BaseSetup.sol Outdated Show resolved Hide resolved
@byshape byshape merged commit 50e0cd8 into master Aug 19, 2024
4 of 8 checks passed
@byshape byshape deleted the feature/SC-1241-Add-access-token-modifier branch August 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants