Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-1018, SC-1021, SC-1022, SC-1023] EscrowFactory and EscrowRegistry implementation #1

Merged
merged 14 commits into from
Dec 24, 2023
Merged

[SC-1018, SC-1021, SC-1022, SC-1023] EscrowFactory and EscrowRegistry implementation #1

merged 14 commits into from
Dec 24, 2023

Conversation

byshape
Copy link
Contributor

@byshape byshape commented Dec 12, 2023 •
edited
Loading

EscrowFactory and EscrowRegistry were implemented.

  • create3 pattern to deploy a new EscrowRegistry proxy.
  • Two separate functions to deploy on the source and destination chains.
  • The function to deploy on the source chain implements the limit order protocol IPostInteraction interface.

@byshape byshape changed the title [SC-1018] EscrowFactory and EscrowRegistry implementation [SC-1018, SC-1021] EscrowFactory and EscrowRegistry implementation Dec 15, 2023
@byshape byshape marked this pull request as ready for review December 15, 2023 18:06
byshape and others added 12 commits December 18, 2023 12:05
@byshape
Updated structs to deploy escrows
755b060
@byshape
Added functions for token withdrawals and escrow cancellations
ab03965
@byshape
Merge branch 'master' into SC-1022-Withdraw-escrow-features
95ea8e5
@byshape
Merge branch 'master' into SC-1018-EscrowFactory-and-EscrowRegistry-i…
c4b1120 
…mplementation
@byshape
Merge branch 'SC-1018-EscrowFactory-and-EscrowRegistry-implementation…
ea4f5b2 
…' into SC-1022-Withdraw-escrow-features
@byshape
Refactored the use of fixtures
2f663a9
@byshape
Implemented secret verification
a5edbb5
@ZumZoom
review changes (wip)
0a587ab
@ZumZoom
fix lint
32e2dc6
@ZumZoom
Merge pull request #5 from 1inch/fix/review
0df896e 
review changes (wip)
@ZumZoom
Merge pull request #4 from 1inch/SC-1023-Secret-check-function
569a9ac 
[SC-1023] Secret check function
@ZumZoom
Merge pull request #3 from 1inch/SC-1022-Withdraw-escrow-features
3fa2cfe 
[SC-1022] Withdraw escrow features
@ZumZoom ZumZoom changed the title [SC-1018, SC-1021] EscrowFactory and EscrowRegistry implementation [SC-1018, SC-1021, SC-1022, SC-1023] EscrowFactory and EscrowRegistry implementation Dec 24, 2023
@ZumZoom ZumZoom merged commit ac55906 into master Dec 24, 2023
3 checks passed
@ZumZoom ZumZoom deleted the SC-1018-EscrowFactory-and-EscrowRegistry-implementation branch December 24, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZumZoom ZumZoom ZumZoom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byshape @ZumZoom