-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async_any_callback and async_callback macro with it's docs #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments. Thanks a lot for this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
- Coverage 91.95% 91.82% -0.14%
==========================================
Files 36 36
Lines 5073 5124 +51
==========================================
+ Hits 4665 4705 +40
- Misses 408 419 +11 ☔ View full report in Codecov by Sentry. |
Seems like there is an error with formatting, please also fix that :) For the failing test I will investigate what is going on. |
I got it, it's from tokio's feature |
good…… |
I fixed the tokio CI issue in main, feel free to rebase :) |
Just need to fix the doctests and we're good to go! :) |
6db1254
to
d9ef52c
Compare
It would be great to get this into the new version! If the three comments I posted are resolved and all tests pass I am happy to merge. |
@1c3t3a please approval the test, I think it will do it |
hmmm, A quick fix |
19 min "quick fix" |
I think this won't work either, the issue is as I pointed out, that we're missing an async main function. Please take a look at my comment regarding wrapping the code in the comment. |
oh, sorry about that, mybad and it's my bad again |
c35ee3c
to
7e95f2e
Compare
what…… |
just use it from the root add use futures_util::FutureExt;
7e95f2e
to
9f07ae7
Compare
@1c3t3a one last time today, please approve the test |
finally! today is a good day~ |
Great! Finally passed :) Could you please remove the change of base64 version please? Then we're ready to merge! |
@1c3t3a there you go~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much! :)
Do #395