Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default log level when not using RUST_LOG #206

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

darrell-roberts
Copy link
Member

@darrell-roberts darrell-roberts commented Nov 12, 2024

The logger would not initialize unless RUST_LOG was defined.

Fixed this to use default to info and allow RUST_LOG override.

Fixes: #197

Example of parsing errors with change:

[2024-11-12 17:34:16.825715 -05:00] INFO [typeshare] cli/src/main.rs:48: typeshare started generating types
[2024-11-12 17:34:18.855152 -05:00] ERROR [typeshare] cli/src/main.rs:269: Parsing error: "the serde tag attribute is not supported for non-algebraic enums: SomeBadEnum" in file "/Users/darrellroberts/projects/my-proj/src/types.rs"
[2024-11-12 17:34:18.855216 -05:00] ERROR [typeshare] cli/src/main.rs:269: Parsing error: "the serde tag attribute is not supported for non-algebraic enums: AnotherBadEnum" in file "/Users/darrellroberts/projects/my-proj/src/types.rs"
[2024-11-12 17:34:18.855230 -05:00] ERROR [typeshare] cli/src/main.rs:269: Parsing error: "the serde tag attribute is not supported for non-algebraic enums: SomeBadEnum" in file "/Users/darrellroberts/projects/my-proj/src/types.rs"
[2024-11-12 17:34:18.855238 -05:00] ERROR [typeshare] cli/src/main.rs:269: Parsing error: "the serde tag attribute is not supported for non-algebraic enums: AnotherBadEnum" in file "/Users/darrellroberts/projects/my-proj/src/types.rs"
[2024-11-12 17:34:18.855252 -05:00] ERROR [typeshare] cli/src/main.rs:277: Errors encountered during parsing.
Error: Errors encountered during parsing.

@darrell-roberts darrell-roberts changed the title set default log level when not using RUST_LOG Set default log level when not using RUST_LOG Nov 12, 2024
@seanaye seanaye merged commit dce5b85 into 1Password:main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Errors encountered during parsing.
2 participants