Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #689

Open
wants to merge 7 commits into
base: staging
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
This should be with the changes
stevestriker committed Nov 16, 2021
commit 7aa0bcb27eaf8fc1630b8ba0ce5373c7cec908ce
132 changes: 65 additions & 67 deletions src/components/Footer.js
Original file line number Diff line number Diff line change
@@ -6,7 +6,6 @@ import {
textStyle,
useLayout,
useTheme,
useViewport,
} from '@1hive/1hive-ui'
import styled from 'styled-components'
import Layout from './Layout'
@@ -23,85 +22,84 @@ import homeSvg from '../assets/home.svg'

function Footer() {
const theme = useTheme()
const { below } = useViewport()
const compactMode = below('large')

return (
<footer
css={`
flex-shrink: 0;
width: 100%;
padding: ${5 * GU}px ${3 * GU}px;
padding: ${1 * GU}px ${1.3 * GU}px;
background: ${theme.surface};
`}
>
<Layout paddingBottom={0}>
{compactMode ? (
<FixedFooter />
) : (
<Layout paddingBottom={70}>
<FixedFooter />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove the compactMode condition? Note that we only want the Fixed Footer on smaller screen sizes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed cursor:pointer.
Fixed the href properties to direct correctly.
Still need to configure the compact mode footer tooldbar.

<div
css={`
display: grid;
padding: 0px 0px 30px 10px;
grid-template-columns: repeat(auto-fit, minmax(100px, 0.3fr));
grid-row-gap: ${2 * GU}px;
& a {
color: ${theme.contentSecondary};
}
`}
>
<div>
<img src={logoSvg} height="40" alt="" />
</div>
<div
css={`
display: grid;
grid-template-columns: ${40 * GU}px ${25 * GU}px ${25 * GU}px;
grid-row-gap: ${2 * GU}px;

& a {
color: ${theme.contentSecondary};
}
line-height: 0.5;
`}
>
<div>
<img src={logoSvg} height="40" alt="" />
</div>
<div>
<h5
css={`
${textStyle('body1')};
margin-bottom: ${1.5 * GU}px;
`}
>
Community
</h5>
<Link href="https://discord.gg/4fm7pgB" external>
Discord
</Link>
<Link href="https://github.com/1Hive" external>
Github
</Link>
<Link href="https://twitter.com/1HiveOrg" external>
Twitter
</Link>
<Link href="https://t.me/honeyswapdex" external>
Telegram
</Link>
<Link href="https://forum.1hive.org/" external>
Forum
</Link>
</div>
<div>
<h5
css={`
${textStyle('body1')};
margin-bottom: ${1.5 * GU}px;
`}
>
Documentation
</h5>
<Link href="https://1hive.gitbook.io/1hive/" external>
Wiki
</Link>
<Link
href="https://1hive.gitbook.io/1hive/community/security/bug-bounty"
external
>
Bug Bounty
</Link>
<Link href="https://1hive.gitbook.io/1hive/guides/faq" external>
FAQs
</Link>
</div>
<h5
css={`
${textStyle('body1')};
margin-bottom: ${1.5 * GU}px;
`}
>
Community
</h5>
<Link href="https://discord.gg/4fm7pgB" external>
Discord
</Link>
<Link href="https://github.com/1Hive" external>
Github
</Link>
<Link href="https://twitter.com/1HiveOrg" external>
Twitter
</Link>
<Link href="https://t.me/honeyswapdex" external>
Telegram
</Link>
<Link href="https://forum.1hive.org/" external>
Forum
</Link>
</div>
<div>
<h5
css={`
${textStyle('body1')};
margin-bottom: ${1.5 * GU}px;
`}
>
Documentation
</h5>
<Link href="https://1hive.gitbook.io/1hive/" external>
Wiki
</Link>
<Link
href="https://1hive.gitbook.io/1hive/community/security/bug-bounty"
external
>
Bug Bounty
</Link>
<Link href="https://1hive.gitbook.io/1hive/guides/faq" external>
FAQs
</Link>
</div>
)}
</div>
)
</Layout>
</footer>
)