Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update discord links #27

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

kamikazebr
Copy link
Member

@kamikazebr kamikazebr commented Sep 15, 2022

Fixing Discord Invites links

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
about-1hive ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 4:32PM (UTC)

Copy link

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can extract it in constant.js?

@kamikazebr
Copy link
Member Author

kamikazebr commented Sep 26, 2022

Maybe you can extract it in constant.js?

Ohh its look good idea, the link in Markdown only will not be possible to change. I like that suggestion.

EDIT:
I tried
image

But some problems with import.

@Corantin
Copy link

Maybe you can extract it in constant.js?

Ohh its look good idea, the link in Markdown only will not be possible to change. I like that suggestion.

EDIT: I tried image

But some problems with import.

You had to use :
const {DISCORD_INVITE_URL} = require('./constant')
but it doesn't mater since you also have to change it in markdown so its not a huge utility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants