Records with different terms and tabs #62
Conversation
| @@ -57,7 +58,7 @@ const Assistant = ({ message, itemId }: AssistantProps) => { | |||
| <Media | |||
| e2e="assistant-iframe" | |||
| key={uuidV4()} | |||
| title={it[it.type]?.title||''} | |||
| title={it[it.type]?.title || ''} | |||
| background={`url(https://img.youtube.com/vi/${extractVideoCode(it[it.type]?.url)}/hqdefault.jpg)`} | |||
| url={extractVideoCode(it[it.type]?.url || 'https://www.youtube.com/embed/g4B8Dhl4pxY')} | |||
| type={Definition.video} | |||
There was a problem hiding this comment.
@IlievaDayana I don't see any fallback for the background similar to the one for url attribute. Can you provide something?
| @@ -142,6 +143,7 @@ const chatMiddleware: Middleware = (store) => (next) => (action) => { | |||
| } | |||
|
|
|||
| if (resendMessage.match(action) && !('$isSync' in action)) { | |||
| // @ts-ignore must understand why the action is of type never?? | |||
| handleMessageResending(action.payload); | |||
| } | |||
There was a problem hiding this comment.
@IlievaDayana What happens if you check existence of payload property in action before use and what is actual type of Action from Redux toolkit? You can try to define interface that extends Action and put required properties in it then pass it for chatMiddleware parameter.
There was a problem hiding this comment.
i've tried adding type check also property check and both also, but it did not work?
Action where T stands for template, maybe i should describe it somehow.
IlievaDayana
force-pushed
the
term-tab-in-sync
branch
from
e8924ff to
f8b1154
Compare
IlievaDayana
force-pushed
the
term-tab-in-sync
branch
from
f8b1154 to
24a3384
Compare
| term, | ||
| threadId: threadId, | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@IlievaDayana I see a lot of duplicate objects. You can create factory function that produces mocked objects and call it wherever needed:
const generateStreamingData = (data: Partial<StreamingData>) => ({
type: 'text',
text: '',
sequence: 1,
id: '4216d0a8-2621-499c-8a65-70191e31ee5a',
term: '',
threadId: faker.random.uuid(),
...data
});
| errors: [], | ||
| term: term, | ||
| threadId: threadId, | ||
| }); |
There was a problem hiding this comment.
@IlievaDayana you can pass term and threadId only once for short version.
{
...
term,
threadId
}
| } | ||
|
|
||
| return 0; | ||
| }; | ||
|
|
There was a problem hiding this comment.
@IlievaDayana Do you plan to add tests for these methods?
src/components/Stream/bubble.tsx
Outdated
| sent: record.sent || true, | ||
| groupId: record.groupId || '', | ||
| itemId: itemId | ||
| }} |
There was a problem hiding this comment.
@IlievaDayana could be passed only once:
{
...
itemId
}
No description provided.