Add symbol replacer for new lines #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlievaDayana
force-pushed
the
Adding-new-lines-functionality
branch
from
260f401 to
1f6e808
Compare
venzovisa
reviewed
Mar 19, 2024
|
|
||
| export const splitIntoRowChunks = (text: string): string[] => { | ||
| return text.replaceAll(/\\r\\n|\\n|\r\n|<br>|<br\/>/g, '\n').split('\n'); | ||
| }; |
There was a problem hiding this comment.
@IlievaDayana You could add some test for this function as well splitIntoRowChunks
There was a problem hiding this comment.
there is, it is just a feature test that is testing both visually and by calling this function and asserting that the states are equal
venzovisa
approved these changes
Mar 19, 2024
IlievaDayana
force-pushed
the
Adding-new-lines-functionality
branch
4 times, most recently
from
09d203e to
a530037
Compare
IlievaDayana
force-pushed
the
Adding-new-lines-functionality
branch
from
a530037 to
3ae1082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.