Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path issue with override container #246

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix path issue with override container #246

merged 2 commits into from
Jul 17, 2024

Conversation

hugosolar
Copy link
Contributor

@hugosolar hugosolar commented Jul 17, 2024 •
edited by dkotter
Loading

Description of the Change

Fix path issue due to some override container checks.

Closes #244

How to test the Change

Where possible, please also include:

  • In the settings enable CNAME
  • create a dummy post and add an image
  • Save & publish the post
  • In the frontend verify srcset paths are correct
  • Verify container name is correct
  • Set an override container name
  • Go back to the dummy post
  • add an image
  • in the frontend verify srcset paths and container names are correct

Changelog Entry

Fixed - Fix path issue that shows the container name duplicated in URL paths

Credits

Props @hugosolar, @cally423, @Besdima, @ms2oo8, @BCornelissen

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@hugosolar hugosolar self-assigned this Jul 17, 2024
dkotter
dkotter requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but otherwise code looks good.

Does this also close #243?

windows-azure-storage-util.php Outdated Show resolved Hide resolved
@dkotter dkotter linked an issue Jul 17, 2024 that may be closed by this pull request
Custom CNAME container name dublication in URL #243
Closed
1 task
@dkotter dkotter merged commit 4c1cc1c into develop Jul 17, 2024
8 checks passed
@dkotter dkotter deleted the fix/add_storage_container_override_path branch July 17, 2024 16:24
@jeffpaul jeffpaul modified the milestones: 4.6.0, 4.5.1 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

@rickalee rickalee Awaiting requested review from rickalee rickalee is a code owner

Assignees

@hugosolar hugosolar

Labels
None yet
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

Duplicating container directory in image address URL Custom CNAME container name dublication in URL
3 participants
@hugosolar @dkotter @jeffpaul