Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/small optimizations #332

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Feature/small optimizations #332

merged 4 commits into from
Feb 9, 2024

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Feb 7, 2024

Small optimizations in some of the most used lines of the rom.
Optimized 200k steps from a batch full of uniswap swaps

  • Moved push size to map-opcodes file
  • Joined 3 lines in one at checkJumpDest
  • Removed binary from getCalldataCost
  • Removed binary + steps from offsetUtil

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2024
@krlosMata krlosMata force-pushed the feature/small-optimizations branch from 3fa7c75 to b9ba80f Compare February 7, 2024 14:04
@krlosMata krlosMata marked this pull request as draft February 8, 2024 16:28
@ignasirv ignasirv force-pushed the feature/small-optimizations branch 2 times, most recently from b99fa2a to a36998b Compare February 9, 2024 08:04
@ignasirv ignasirv changed the base branch from develop-feijoa to develop-eldelberry February 9, 2024 08:20
@ignasirv ignasirv marked this pull request as ready for review February 9, 2024 08:20
@krlosMata krlosMata force-pushed the feature/small-optimizations branch from a36998b to 44d3961 Compare February 9, 2024 10:45
krlosMata
krlosMata approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@krlosMata krlosMata merged commit e6bef57 into develop-eldelberry Feb 9, 2024
4 checks passed
@ignasirv ignasirv deleted the feature/small-optimizations branch February 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @krlosMata