Refactor and huge optmization of the ecrecover #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecmas
requested review from
laisolizq,
krlosMata and
zkronos73
as code owners
krlosMata
force-pushed
the
feature/ecrecover-ref-optz
branch
from
1128440 to
2ec5cfa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a significant improvement (in the sense of number of steps) of the
dblScalarMulSecp256k1function. In particular, in order to avoid using memory variables that are used to reconstruct the scalars, we use small registersRCXandHASHPOSfor this end, which are reset every 32-bit cycle.sm_main_exec.jsof theproverjsneeds to be corrected, since thefe2n()function is incorrectly throwing an error when the small registers are larger than 31 bits. Solved in PR 242 of zkevm-proverjs.EcRecover Refactor: A complete refactor of the
ecrecoverfolder has also been done, along with some major optimizations to the double scalar multiplication needed for the public key recovery. See the PR for more details.