Code optimization #374
Open
Code optimization #374
+210
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common parameters for networks are entered in the createNetworkConfig function, which automatically builds the configuration for each network. This eliminates duplication. All compilers use the same optimizer setting (for most contracts). This is submitted to the COMPILER_SETTINGS constant. Account configuration is now stored in one ACCOUNTS_CONFIG object, which is used for all networks. Flexibility is applied through the use of the INFURA_URL variable, which makes it easy to change the URL for providers without having to copy the same code
Instead of prescribing the path to artifacts for each contract every time, I created an artifactsPath object that stores the path to all the necessary files. This makes it easy to control and change paths in one place. To improve readability and reduce repeating code, I have taken repeated actions into separate functions Renamed some variables to improve code readability Excess or non-informative comments have also been removed, for example, indications of the location of files that are now processed automatically. --------------------------------------------------- there were typos in the original contract if you decide to leave it: conracts - contracts, btyecode - bytecode "deployMainnet.polygonZkEVMBridgeAddress" and other proxy addresses are checked several times. It is better to check each address specifically in the context of his contract to avoid confusion. Printout:"polygonZkEVMGlobalImpl" must be "polygonZkEVMGlobalExitRootImpl" so that the variable name matches the content. and few more
Fixed typos lets - let’s Tweeking - Tweaking exactlly - exactly transacction - transaction bycode - bytecode
|
We require contributors/corporates @Cherkaso8 to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The pull request includes the following changes:
Artifact Import Optimization:
verifyMainnetDeployment.jsfile, which used different paths for the same files.Documentation Updates:
verifyTestnetProofVerifier.mdfile:Code Optimization:
Technical Changes:
Overall, the code and documentation readability have been improved, redundancies eliminated, and the process clarified.