Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tool to change minDelay timelock #364

Open
wants to merge 3 commits into
base: feature/ongoingPP
Choose a base branch
from
Open

add tool to change minDelay timelock #364

wants to merge 3 commits into from
+165 −0

Conversation

laisolizq
Copy link
Contributor

@laisolizq laisolizq commented Dec 5, 2024 •
edited
Loading

This PR includes the tool to change the minDelay of the PolygonZkEVMTimelock contract.

@laisolizq laisolizq requested a review from krlosMata December 5, 2024 11:24
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
krlosMata
krlosMata requested changes Dec 5, 2024
View reviewed changes
tools/changeDelayTimelock/.gitignore Outdated Show resolved Hide resolved
tools/changeDelayTimelock/changeDelayTimelock.ts Outdated Show resolved Hide resolved
@laisolizq laisolizq requested a review from krlosMata December 5, 2024 11:42
@laisolizq laisolizq force-pushed the feature/add-tool-change-delay branch from a5ead63 to 74460bd Compare December 5, 2024 13:45
@laisolizq laisolizq requested a review from krlosMata December 5, 2024 13:46
krlosMata
krlosMata approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

tools/changeDelayTimelock/changeDelayTimelock.ts Outdated
};
}

function wait(seconds: number): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function not used

@laisolizq laisolizq force-pushed the feature/add-tool-change-delay branch from 74460bd to 8fa4f45 Compare December 5, 2024 13:55
@laisolizq laisolizq force-pushed the feature/add-tool-change-delay branch from 02b1859 to ff1ebfa Compare December 5, 2024 14:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

krlosMata
krlosMata approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laisolizq @krlosMata