Merge pull request #393 from 0xPolygonHermez/feature/comments_and_int…

…erfaces comments and interfaces
0xPolygonHermez · Jan 29, 2025 · a512a25 · a512a25
2 parents 17bb90d + 202f52d
commit a512a25
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/contracts/lib/TokenWrappedBridge.sol b/contracts/lib/TokenWrappedBridge.sol
@@ -4,6 +4,9 @@ pragma solidity 0.8.17;
 
 import "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 
+// This contract contains the solidity code that compiles into the BASE_INIT_BYTECODE_WRAPPED_TOKEN constant on the PolygonZkEVMBridgeV2
+// This contract should remain untouched, even if it's not used directly as dependency. The main use is to verify on block explorers
+// and check the implementation.
 contract TokenWrappedBridge is ERC20 {
     // Domain typehash
     bytes32 public constant DOMAIN_TYPEHASH =

diff --git a/contracts/v2/interfaces/IPolygonConsensusBase.sol b/contracts/v2/interfaces/IPolygonConsensusBase.sol
@@ -12,5 +12,5 @@ interface IPolygonConsensusBase {
         string memory _networkName
     ) external;
 
-    function admin() external returns (address);
+    function admin() external view returns (address);
 }
diff --git a/contracts/v2/interfaces/IPolygonRollupManager.sol b/contracts/v2/interfaces/IPolygonRollupManager.sol
@@ -390,22 +390,24 @@ interface IPolygonRollupManager {
 
     function setBatchFee(uint256 newBatchFee) external;
 
-    function getRollupExitRoot() external returns (bytes32);
+    function getRollupExitRoot() external view returns (bytes32);
 
-    function getLastVerifiedBatch(uint32 rollupID) external returns (uint64);
+    function getLastVerifiedBatch(
+        uint32 rollupID
+    ) external view returns (uint64);
 
-    function calculateRewardPerBatch() external returns (uint256);
+    function calculateRewardPerBatch() external view returns (uint256);
 
-    function getBatchFee() external returns (uint256);
+    function getBatchFee() external view returns (uint256);
 
-    function getForcedBatchFee() external returns (uint256);
+    function getForcedBatchFee() external view returns (uint256);
 
     function getInputPessimisticBytes(
         uint32 rollupID,
         bytes32 selectedGlobalExitRoot,
         bytes32 newLocalExitRoot,
         bytes32 newPessimisticRoot
-    ) external returns (bytes memory);
+    ) external view returns (bytes memory);
 
     function getInputSnarkBytes(
         uint32 rollupID,
@@ -414,12 +416,15 @@ interface IPolygonRollupManager {
         bytes32 newLocalExitRoot,
         bytes32 oldStateRoot,
         bytes32 newStateRoot
-    ) external returns (bytes memory);
+    ) external view returns (bytes memory);
 
     function getRollupBatchNumToStateRoot(
         uint32 rollupID,
         uint64 batchNum
-    ) external returns (bytes32);
+    ) external view returns (bytes32);
 
-    function lastDeactivatedEmergencyStateTimestamp() external returns (uint64);
+    function lastDeactivatedEmergencyStateTimestamp()
+        external
+        view
+        returns (uint64);
 }