-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Division check for arith component #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Custom cols rom (#159) Custom cols working --------- Co-authored-by: Xavier Pinsach <[email protected]> * Cached custom commits * Updating proofman to 0.0.12 * Cargo fmt * Cargo fmt * Fix cargo clippy * Rom trace is now deterministic * cargo fmt * Global constraints verifying again * Optimizing the binary component (#167) * Optimizing the binary * Updating the executor * Updating to 0.0.13 * Not creating unnecessary instances of arith tables * Pil2-proofman 0.0.14 --------- Co-authored-by: Xavier Pinsach <[email protected]> Co-authored-by: Héctor Masip Ardevol <[email protected]>
hecmas
force-pushed
the
feature/lt-abs
branch
from
December 3, 2024 17:39
f8baaad
to
d401515
Compare
hecmas
force-pushed
the
feature/lt-abs
branch
from
December 9, 2024 17:58
7bfa133
to
9169098
Compare
hecmas
force-pushed
the
feature/lt-abs
branch
from
December 10, 2024 16:06
8255698
to
a6dfade
Compare
hecmas
force-pushed
the
update_proofman
branch
from
December 11, 2024 11:14
f88f3e3
to
370159a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the constraint to the arith component where a division check is performed:
For this, we needed to implement three new binary operations:
LT_ABS_NP_OP
: Checks that the first input, assumed to be negative, is strictly lower than the second input, assumed to be positive, in absolute value.LT_ABS_PN_OP
: Checks that the first input, assumed to be positive, is strictly lower than the second input, assumed to be negative, in absolute value.GT_OP
: Check that the first input is strictly bigger than the second input.Adding these binary operations incurred in doubling the size of the binary table, so that all possible combinations regarding them are included in the table.