Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, fixes and optimizations of std #137

Closed
wants to merge 7 commits into from
Closed

Conversation

hecmas
Copy link
Contributor

@hecmas hecmas commented Dec 11, 2024

This PR adds the following features to the pil2 STD:

  • Add support for the Baby-Bear field with order $p = 2^{31} - 2^{27}+1$.
  • Add support for "free" permutation in product checks.
  • Both sum checks and product checks now hint data related to the air that uses them.
  • Improved format for debug mode:
    [ERROR] STD Prod: Some bus values do not match.
            ► Mismatched bus values for opid 4:
              ⁃ There are 1 unmatching values thrown as 'assume':
                ==================================================
                • Value:
                    [102, 101]
                  Appears 128 times across the following:
                    - Airgroup: Permutation (id: 0)
                      Air: Permutation1_6 (id: 0)
                      PIOP: Permutation
                      Expression: ["Permutation1_6.a4", "Permutation1_6.b4"]
                      Instance ID: 0 | Num: 64 | Rows: [0,1,2,3,4,5,6,7,8,9,...]
                    - Airgroup: Permutation (id: 0)
                      Air: Permutation1_6 (id: 0)
                      PIOP: Permutation
                      Expression: ["Permutation1_6.a4", "Permutation1_6.b4"]
                      Instance ID: 1 | Num: 64 | Rows: [0,1,2,3,4,5,6,7,8,9,...]
                --------------------------------------------------
                Total Num Assumes: 128.
                Total Num Proves: 0.
                Total Unmatched: 128.
                ==================================================
  • The std executors now does not scan all PILs to find their data but instead read global hints that hint them what airgroup/air they have to look at.
  • Add a example diff_buses that deals with the possibility of having different buses being used in the same airgroup and/or air.
  • Add a example direct_update that uses different pil features and components to perform direct updates of both the product and the sum constraints.

@cla-bot cla-bot bot added the cla-signed label Dec 11, 2024
@hecmas hecmas self-assigned this Dec 11, 2024
@hecmas hecmas changed the title Cleanup, fixes and optimizations of range check Cleanup, fixes and optimizations of std Dec 11, 2024
@hecmas hecmas marked this pull request as ready for review December 12, 2024 18:18
@hecmas hecmas mentioned this pull request Dec 20, 2024
16 tasks
@hecmas hecmas marked this pull request as draft December 20, 2024 15:45
@RogerTaule RogerTaule closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants