fix: unreadable symbols in DS stream on client side #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBelyakoff
requested review from
revitteth,
hexoscott,
mandrigin and
eduadiez
as code owners
IvanBelyakoff
force-pushed
the
fix/ds_unreadable_symbols
branch
2 times, most recently
from
e6eaaf4 to
cbf3ab4
Compare
IvanBelyakoff
force-pushed
the
fix/ds_unreadable_symbols
branch
from
cbf3ab4 to
872d33e
Compare
revitteth
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
allowStopsflag in stream client, that was introduced for testing but default false value broke Stop implementation.Read CmdStop response to avoid leaving it in connection buffer as connection is kept alive.
Fixed
streamingflag not always set properly.Fixed setting lastError properly in some cases, improved err handling/shadowing.
Improved Stop() calls handling. Stream stopped at stage end now, instead of start of next stage iteration, which led to server could send more data that we would need to drain.