enhance(l1-info-sync): sync l1 info table from l2 rpc id an rpc node #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliothllm
requested review from
revitteth,
hexoscott,
mandrigin and
eduadiez
as code owners
elliothllm
force-pushed
the
enhance/l1-info-sync-speed
branch
from
f7255e3 to
c068e1e
Compare
enhance(l1-info-sync): l2 syncer wip enhance(l1-info-sync): l2 syncer enhance(l1-info-sync): fix tests
elliothllm
force-pushed
the
enhance/l1-info-sync-speed
branch
from
c068e1e to
41a0266
Compare
revitteth
reviewed
Feb 3, 2025
| EXIT_ROOT_TABLE = "zkevm_getExitRootTable" | ||
| ) | ||
|
|
||
| type L2InfoTreeSyncer struct { |
There was a problem hiding this comment.
I think this name is a bit misleading. Can we change the name? Smth like L2RpcL1InfoTreeSyncer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The L2 Info Tree syncer will collect all the Info Tree from the L2 in a configurable batch size.
zkevm.l2-info-tree-updates-batch-size. You will need to enable this using flagzkevm.l2-info-tree-updates-enabled. It will try to usezkevm_getExitRootTablewith updated params "to" and "from".A fail safe is in place. If we error out during L2 sync phase then we continue to use L1 method, if we succeed then return. We only enter the L2 sync phase when (RPC node, progress == 0, config enabled).