Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ds max chann entry config #1597

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

zjg555543
Copy link

issue

  • In the XLayer testnet, when synchronizing blocks from 0, the following error occurs: the data stream relay sends too fast, but the client cannot process it in time, causing the relay to forcibly terminate the TCP connection.
[INFO] [12-26|07:15:37.066] Starting L1 syncer thread 
[INFO] [12-26|07:15:37.792] [2/16 L1InfoTree] Info tree updates      count=2 latestIndex=151882
[INFO] [12-26|07:15:37.793] [2/16 L1InfoTree] Finished L1 Info Tree stage 
[INFO] [12-26|07:15:37.793] [3/16 Batches] Starting batches stage 
[INFO] [12-26|07:15:37.793] [Datastream client] Starting datastream client from cold 
[INFO] [12-26|07:15:38.347] [3/16 Batches] Highest block in datastream datastreamBlock=20616385 stageProgressBlockNo=12788219
[INFO] [12-26|07:15:38.347] [3/16 Batches] Reading blocks from the datastream. 
[INFO] [12-26|07:15:38.348] [3/16 Batches] Started downloading L2Blocks routine ID: 748875 
[INFO] [12-26|07:15:48.347] [3/16 Batches] Downloaded blocks from datastream progress: 12459 
[INFO] [12-26|07:15:58.347] [3/16 Batches] Downloaded blocks from datastream progress: 13265 
[INFO] [12-26|07:16:08.348] [3/16 Batches] Downloaded blocks from datastream progress: 13992 
[WARN] [12-26|07:16:11.514] Error in datastream client, stopping consumption 
[INFO] [12-26|07:16:11.514] [3/16 Batches] Total blocks written: 14873 
[INFO] [12-26|07:16:11.514] [3/16 Batches] Saving stage progress     lastBlockHeight=12803092
[INFO] [12-26|07:16:11.514] [3/16 Batches] Finished writing blocks   blocksWritten=14873 elapsed=33.721673063s
[INFO] [12-26|07:16:11.514] [3/16 Batches] Finished Batches stage 
[WARN] [12-26|07:16:11.514] [3/16 Batches] Error downloading blocks from datastream error="readAllFullL2BlocksToChannel: NextFileEntry: reading file data bytes: readBuffer: socket error: io.ReadFull: unexpected EOF"
[INFO] [12-26|07:16:11.514] [3/16 Batches] Ended downloading L2Blocks routine ID: 748875 

approach

  • This PR attempts to increase the channel buffer and exit the synchronization logic only after the buffer is processed.

@cla-bot cla-bot bot added the cla-signed label Dec 30, 2024
Copy link
Collaborator

@afa7789 afa7789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit.

with a flag.

@mandrigin mandrigin enabled auto-merge (squash) January 10, 2025 15:59
@mandrigin mandrigin merged commit ca5ef6b into 0xPolygonHermez:zkevm Jan 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants