Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move paths.csv to db #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hoeflechner
Copy link
Contributor

i moved the paths.csv file to the db directory so that all variable stuff is in one place. the docker container will benefit from this as only one directory needs to be mounted from the host

@0ssamaak0
Copy link
Owner

Idk if this is correct or not, the db directory is created by chromadb as the path of the vector database.
Should we add anything inside it? Or should we create a parent dir that includes both the db dir and paths.csv?

@hoeflechner
Copy link
Contributor Author

that ist probably even better!
btw i was wondering if the cromadb could be used instead of the csv file?

@0ssamaak0
Copy link
Owner

To store the paths? I think it's an overkill. There's no need for the vector database functionality just to store them.

@hoeflechner
Copy link
Contributor Author

not as a vector of course. but the db already contains the paths as id

@0ssamaak0
Copy link
Owner

The database itself is constructed from the CSV itself. I think merging both steps is not a good idea. But putting everything in a single directory may be!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants