fix(useScript): variable scope bug that stops scripts being unmounted

[webdevian]

I ran into this bug when testing for scripts being removed from the DOM.

When the script element is first created (L32) it was not assigned to the script variable that the useEffect return function is using to remove the element (L57)

[changeset-bot]

🦋 Changeset detected

Latest commit: b7052a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
hoofd	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[JoviDeCroock]

Needs a changeset

[webdevian]

I've never used changesets before and can't see any that exist in the repo but I clicked the link above and it seems to have created one

[JoviDeCroock]

@webdevian can you rebase this against main?

[webdevian]

@JoviDeCroock I think that is done now?

[JoviDeCroock]

@webdevian you have failing tests

[webdevian]

Ok, the 2 failing tests aren't working in main either. The existing tags aren't being reused, it is adding duplicate tags to the head

stdout | __tests__/useScript.test.tsx > useScript > should reuse an existing tag
<script type="application/javascript" crossorigin="anonymous" async="true" src="test.js"></script><script crossorigin="anonymous" src="test.js" async="true"></script>

stdout | __tests__/useScript.test.tsx > useScript > should reuse an existing tag to fill text
<script crossorigin="anonymous" src="test.js" async="true"></script><script type="application/ld+json" id="rich-text">{"key":"value"}</script><script type="application/ld+json" id="rich-text"></script>

I will make some changes to useScript and to the tests

[JoviDeCroock]

@webdevian They do work on main https://github.com/0no-co/hoofd/actions/runs/12714681359/job/35445316145

[webdevian]

They pass, but they are not actually testing that existing script tag is re-used, just that a new tag is present in the head.

See my updated tests for more explicit checks on number of script elements, and checking the attributes without a full string comparison. I've also had to change the hook to allow preExistingElements[0] to be modified

[webdevian]

I've also added a couple of tests for the unmount