Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udhay/cleanup whole doc #96

Merged
merged 6 commits into from
Jan 11, 2025

Conversation

udhaykumarbala
Copy link
Collaborator

@udhaykumarbala udhaykumarbala commented Dec 23, 2024

This pull request includes various documentation improvements across several files to enhance clarity and readability. The changes mainly focus on refining the language, improving the structure, and updating certain sections for better comprehension.


This change is Reviewable

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
0g-doc-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 10:45am

meeshhhh
meeshhhh previously approved these changes Jan 9, 2025
Copy link
Collaborator

@meeshhhh meeshhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, please revise then feel free to merge! I've preemptively approved

docs/0g-chain.md Outdated Show resolved Hide resolved
docs/0g-chain.md Outdated Show resolved Hide resolved
docs/da/0g-da-deep-dive.md Outdated Show resolved Hide resolved
docs/0g-compute.md Outdated Show resolved Hide resolved
docs/intro.md Outdated Show resolved Hide resolved
@@ -223,7 +224,7 @@ As a DA node operator, your node will perform the following tasks:

## Conclusion

You have now successfully set up and run a 0g DA node as a DA Signer. For more advanced configuration options and usage instructions, please refer to the official GitHub repository.
You have now successfully set up and run a 0g DA node as a DA Signer. For more advanced configuration options and usage instructions, please refer to the [Official GitHub repository](https://github.com/0glabs/0g-da-node).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we repeat this in lines 108 and 227? Let's only keep in one place

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have three tab items.
Two tabs are dedicated to the DA node (via Docker and source), both requiring the same statement, which remains essential in each.

The last tab focuses on the DA Signer, with its content kept distinct and so we cannot move the common lines out of TabItem.

@udhaykumarbala udhaykumarbala merged commit 679074a into 0glabs:main Jan 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants