[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] #299

soaresa · 2024-08-05T17:17:05Z

This PR includes features, fixes, and refactors mainly related to the Proof of Fee module:

Reduces the number of seats after boot-up threshold, improving bid competition between qualified bidders PoF issue with equal bids for lowest, and set sizes equal to bidders #251.
Shuffles validator addresses with the same bid value after bubble sort, ensuring randomness and fixing issue Sorting Algorithm and Fairness in Validator Seat Allocation #271.
Fixes problems related to subsidy allocation for validators' reward payments as described in issue Last Validator No Rewards #241.

Move Test Coverage:

Test Coverage	Overall Score %	#Tests
Before	68.52	303
After	70.08	349
Diff.	1.56	29

Move Test Coverage Score per Module:

Module	Before	After	Diff
address_utils	-	100.00	100.00
pledge_accounts	5.92	32.42	26.50
infra_escrow	27.27	47.73	20.46
musical_chairs	75.74	79.50	3.76
burn	58.00	61.50	3.50
randomness	44.27	44.71	0.44
genesis	47.84	48.14	0.30

soaresa · 2024-08-05T17:18:40Z

Replay PR of #292

0o-de-lally

LGTM. Replay of previous PR after changes to main

…r more compliant

clean up code

test subsidy, fees and reward payments

fixes tests broken by mock changes

creates view query_reward_adjustment

…e duplicates

…bidders (replay PR)[breaking] (#299)

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

…bidders (replay PR)[breaking] (#299)

soaresa requested a review from 0o-de-lally August 5, 2024 17:17

0o-de-lally approved these changes Aug 5, 2024

View reviewed changes

soaresa added 16 commits August 5, 2024 14:24

shuffles validators with same bid value

6c65549

reduces val set for competition between qualified bidders having 21 o…

6cf0e6f

…r more compliant

initializes randomness on ol_reconfigure_for_test

15b55fb

refactors musical chairs mod and adds more tests

7a761fb

gitignore target folders, and move coverage files

0671c3c

fixes reward thermostat call order - WIP

0ee11d8

clean up code

fix budget to collect, and fee calculus

b16d97e

test subsidy, fees and reward payments

test subsidy and rewards having a non compliant val

2afd4e9

test that entry fee sum is burnt on epoch trigger

a01514e

adds tests to reward_thermostat increasing and decreasing rewards

f6ab542

fixes tests broken by mock changes

extracts pure function from reward_thermostat and adds tests

58bbe96

creates view query_reward_adjustment

fixes persist_genesis smoke test

e3ceeb0

applies rlint

cf21355

initializes randomness data

c86d64b

creates address_utils module to host bubble sort algorithm and shuffl…

17d3369

…e duplicates

updates pof competitive pct parameter

5103549

soaresa force-pushed the breaking/pof_tiebreaker_cherry_pick branch from 2ffd090 to 5103549 Compare August 5, 2024 17:24

0o-de-lally marked this pull request as ready for review August 5, 2024 18:26

0o-de-lally merged commit ec9dc2a into 0LNetworkCommunity:main Aug 5, 2024
12 checks passed

0o-de-lally changed the title ~~[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR)~~ [move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] Aug 5, 2024

0o-de-lally pushed a commit that referenced this pull request Aug 5, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

67b70b8

…bidders (replay PR)[breaking] (#299)

0o-de-lally pushed a commit that referenced this pull request Aug 8, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

233f574

…bidders (replay PR)[breaking] (#299)

0o-de-lally pushed a commit that referenced this pull request Aug 8, 2024

[move] pof tiebreaker randomize tied bids, maintain fewer seats than …

11a0859

…bidders (replay PR)[breaking] (#299)

soaresa mentioned this pull request Aug 12, 2024

Enhance Monitoring of Validator Metrics 0LNetworkCommunity/explorer#52

Open

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

492d4f1

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

237b84f

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

1526396

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

9d49b5f

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

65088e6

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

cc1050c

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

cda9892

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

015d747

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

9931dda

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

87fefe8

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

5b3a4c2

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

2547315

…bidders (replay PR)[breaking] (0LNetworkCommunity#299)

0o-de-lally pushed a commit that referenced this pull request Aug 17, 2024

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than …

9368e85

…bidders (replay PR)[breaking] (#299)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] #299

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] #299

soaresa commented Aug 5, 2024

soaresa commented Aug 5, 2024

0o-de-lally left a comment

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] #299

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders (replay PR) [breaking] #299

Conversation

soaresa commented Aug 5, 2024

soaresa commented Aug 5, 2024

0o-de-lally left a comment

Choose a reason for hiding this comment