Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders #277

Closed
wants to merge 62 commits into from
Closed

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders #277

wants to merge 62 commits into from

Conversation

soaresa
Copy link
Contributor

@soaresa soaresa commented Jul 10, 2024 •
edited
Loading

Test Coverage Previous Value New Value
Proof of Fee 87.31% 90.21%
Musical Chairs 75.74% 79.50%

TODO: rebase with main

soaresa added 30 commits July 3, 2024 17:56
@soaresa
feat multi action offer - WIP
338942d
@soaresa
set error codes for offer functions
624366b
@soaresa
adds more tests to multi action offer
1c53ca8
@soaresa
applies canonical errors to offer functions, and creates more tests
c559c56
@soaresa
supports submit new offers, and adds more tests
a93b59c
@soaresa
applies new offer flow to the other tests
4e777b4
@soaresa
adds offer flow to new authorities voted
215aa0c
@soaresa
creates multisign signer to offer authorities triggered by vote, and …
844ecc7 
…drop offer after finalize and after last claim
@soaresa
add test finalize multisign account having a pending claim
f1f8c25
@soaresa
adds migration to init offer, and never drop the offer
4ab6b33 
updates tests error codes
@soaresa
adds test for expired offer
51da957
@soaresa
cleans proposed list only when offer is expired
f2ad2bd
@soaresa
adds support for epoch expiration per authority
d64079d
@soaresa
fixes adding to offer authorities voted in different votes before claims
982e79e
@soaresa
clean up
7fb8c36
@soaresa
set max number of offer addresses to avoid DoS
b514a65
@soaresa
test default value of epochs to expire
144ceb8
@soaresa
ensure proposed list is distinct addresses and without owner
aca7a3e
@soaresa
adds tests for offer migration
3deef10
@soaresa
ensures gov proposes cannot have invalid, duplicated and owner address
b0a4697
@soaresa
adds new constraints and tests to multi_action governance
5b93f95
@soaresa
refactoring
25920d5
@soaresa
fixes indentation
478f298
@soaresa
creates module multi_action_migration - WIP
f93471f
@soaresa
converts error codes to decimal notation
2196e88
@soaresa
sets expire epoch to use offer migration
1fe8892
@soaresa
converts exist_offer into a view function
d8ce53a
@soaresa
comments code not used and not tested
a9156a0
@soaresa
fixes indentation
a8ed2b7
@soaresa
adds test try to vote twice on the same ballot
7cf6715
soaresa added 21 commits July 3, 2024 17:56
@soaresa
set multi_action propose_offer not a transaction
626040a
@soaresa
implementing first smoke test to create community wallet with offer/c…
9c1559d 
…laim pattern
@soaresa
community wallet cli test refactoring
aac268f
@soaresa
prints a message after txs completed and update test comments
3cc0a35
@soaresa
adds propose_offer cli and smoke test update_community_wallet_offer
0dfda8c
@soaresa
create test vote new signer to cw + migrate cw tests to community_wal…
8df804f 
…let.rs
@soaresa
fix threshold bug to remove admin from cw + add test to vote removal …
4dba4a4 
…of admin from cw
@soaresa
cargo fmt && cargo clippy
dad399c
@soaresa
improves cw tests, fix a threshold bug, duplicated error codes, and e…
d0be967 
…rror codes usage
@soaresa
adds CLI and smoke test for offer migration
cd9d778
@soaresa
fix threshold check to reduce cw admins
ca2a01b
@soaresa
Updates community wallet activation doc with the new offer/claim pattern
08824e6
@soaresa
adds offer migration test with twin db
5e10a3c
@soaresa
applies fmt --all
b6ff6a7
@soaresa
fixes linting errors
0c27984
@soaresa
updates a constant name
c0e7b5d
@soaresa
Merge branch 'main' into feat/multi_action_confirmation
e4aeab5
@soaresa
lint fixes
c1d4232
@soaresa
lint fixes for libra framework sdk builder
e159fef
@soaresa
shuffles validators with same bid value
12404ef
@soaresa
reduces val set for competition between qualified bidders having 21 o…
c8e6ff2 
…r more compliant
@soaresa soaresa changed the title Shuffles validators with same bid value after bubble sort Improve competition between qualified bidders Jul 12, 2024
@soaresa soaresa changed the title Improve competition between qualified bidders PoF - Improve competition between qualified bidders Jul 12, 2024
@0o-de-lally 0o-de-lally changed the title PoF - Improve competition between qualified bidders [move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders Jul 12, 2024
@0o-de-lally 0o-de-lally linked an issue Jul 12, 2024 that may be closed by this pull request
PoF issue with equal bids for lowest, and set sizes equal to bidders #251
Closed
@soaresa soaresa removed a link to an issue Jul 19, 2024
PoF issue with equal bids for lowest, and set sizes equal to bidders #251
Closed
@soaresa soaresa closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soaresa