add abort to node start if diem-vm was built with testing feature

0LNetworkCommunity · Aug 20, 2024 · 141ace3 · 141ace3
1 parent 58c37cb
commit 141ace3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/tools/cli/Cargo.toml b/tools/cli/Cargo.toml
@@ -18,6 +18,7 @@ clap = { workspace = true }
 diem = { workspace = true }
 diem-config = { workspace = true }
 diem-node = { workspace = true }
+diem-vm = { workspace = true }
 libra-config = { workspace = true }
 libra-framework = { workspace = true }
 libra-genesis-tools = { workspace = true }

diff --git a/tools/cli/src/node_cli.rs b/tools/cli/src/node_cli.rs
@@ -17,7 +17,9 @@ impl NodeCli {
         // Production code should never have been compiled with
         // Test helpers in the MoveVm. This fuction is a safety check.
         // Check that we are not including any Move test natives
-        // diem_vm::natives::assert_no_test_natives(ERROR_MSG_BAD_FEATURE_FLAGS);
+        diem_vm::natives::assert_no_test_natives(
+            "SCARY: somehow your production binaries ended up with testing features. Aborting!",
+        );
 
         // validators typically aren't looking for verbose logs.
         // but they can set it if they wish with RUST_LOG=info