-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): improve colors contrast in dark mode #4092
base: master
Are you sure you want to change the base?
Conversation
@zackbcom got time to checkout this? |
Pull Request Test Coverage Report for Build 13006038884Details
💛 - Coveralls |
@zackbcom I should have fixed missing colors. Is it ok now? Or do you prefer me to only apply the changes on the LR/Zwave ? cc @AlCalzone thoughts? |
Will be able to check tonight/tomorrow. |
I like the general changes as they appear in the screenshots. White text on light green looks odd though, I'd make it dark like you proposed. |
I already fixed the dark text on green so this should be ok, let's also wait for @zackbcom opinion on this |
Fixes #4091