New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passport Error #1

Open

Asher978 opened this issue Aug 28, 2018 · 0 comments

Asher978 commented Aug 28, 2018

Hey..
came around this repo and poked around a bit.
Currently no matter what password you provide, backend will auth you in ....

i think the issue is here....

const passwordMatch = user.comparePassword(password); // isnt this a promise... ?

// so maybe .... changing it to 
const passwordMatch = await user.comparePassword(password);

    if (!passwordMatch) {
      return done(null, false, 'Incorrect password.');
    }

    return done(null, user); 

// and changing this line to not return fixes things. 

done(null, user)

Thoughts....?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment