From 6f283966310af269aa2d1a54eb249e561d42b255 Mon Sep 17 00:00:00 2001 From: Yuki Nishijima Date: Sat, 16 Mar 2019 13:58:15 -0400 Subject: [PATCH] Switch from Poltergeist/Phantomjs over to Selenium/Firefox headless Phantomjs is no longer maintained while Selenium/Firefox are well-maintained. Chrome is sometimes too good and catches developer mistakes too well, and speed is not the most important since there is not a lot of feature specs. --- active_admin-sortable_tree.gemspec | 3 +-- spec/rails_helper.rb | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/active_admin-sortable_tree.gemspec b/active_admin-sortable_tree.gemspec index 7e935e2..bf98230 100644 --- a/active_admin-sortable_tree.gemspec +++ b/active_admin-sortable_tree.gemspec @@ -22,8 +22,7 @@ Gem::Specification.new do |s| s.add_dependency 'sass', '~> 3.1' s.add_development_dependency 'capybara' + s.add_development_dependency 'selenium-webdriver' s.add_development_dependency 'rspec-rails' - s.add_development_dependency 'phantomjs' - s.add_development_dependency 'poltergeist' s.add_development_dependency 'database_cleaner' end diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 8516fcd..1459600 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -6,10 +6,10 @@ require 'rspec/rails' require 'capybara/rails' -require 'phantomjs/poltergeist' +require "selenium-webdriver" require 'database_cleaner' -Capybara.javascript_driver = :poltergeist +Capybara.javascript_driver = :selenium_headless def reload_menus! if Float(ENV['RAILS_VERSION']) >= 4.0