Invalid nil conditions

[delaneyj]

In savepoint.go

[{
	"resource": "zombiezen.com/go/[email protected]/sqlitex/savepoint.go",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "cond",
		"target": {
			"$mid": 1,
			"path": "/golang.org/x/tools/go/analysis/passes/nilness",
			"scheme": "https",
			"authority": "pkg.go.dev",
			"fragment": "cond"
		}
	},
	"severity": 4,
	"message": "impossible condition: nil != nil",
	"source": "nilness",
	"startLineNumber": 95,
	"startColumn": 17,
	"endLineNumber": 95,
	"endColumn": 17
},{
	"resource": "zombiezen.com/go/[email protected]/sqlitex/savepoint.go",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "cond",
		"target": {
			"$mid": 1,
			"path": "/golang.org/x/tools/go/analysis/passes/nilness",
			"scheme": "https",
			"authority": "pkg.go.dev",
			"fragment": "cond"
		}
	},
	"severity": 4,
	"message": "impossible condition: nil != nil",
	"source": "nilness",
	"startLineNumber": 209,
	"startColumn": 17,
	"endLineNumber": 209,
	"endColumn": 17
}]

[zombiezen]

Interesting. So the relevant code is here on line 95:

go-sqlite/sqlitex/savepoint.go

Lines 86 to 100 in a8ad27a

	if *errp == nil && recoverP == nil {
	// Success path. Release the savepoint successfully.
	*errp = Execute(conn, fmt.Sprintf("RELEASE %q;", name), nil)
	if *errp == nil {
	return
	}
	// Possible interrupt. Fall through to the error path.
	if conn.AutocommitEnabled() {
	// There is nothing to rollback.
	if recoverP != nil {
	panic(recoverP)
	}
	return
	}
	}

(The second report on line 209 is a copy & paste of the same.)

This is also present in the crawshaw repository, so this isn't a regression. In examining it, I think this is just dead code, not a defect. However, it would be nice to clean up the surrounding code for easier reading. Thanks for the report.