Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Input format #10

Open
StefanosChaliasos opened this issue Mar 9, 2023 · 2 comments
Open

Update Input format #10

StefanosChaliasos opened this issue Mar 9, 2023 · 2 comments
Assignees
Milestone

Comments

@StefanosChaliasos
Copy link
Collaborator

Update the JSON structure of inputs to contain more details.
Currently, the input JSONs contain only the input values for the circuits.
We might want to add a description field to describe the input, so we can improve the UI.

Old format:

{
    "PreImage": "68656c6c6f20776f726c64",
    "Hash":     "b94d27b9934d3e08a52e52d7da7dabfac484efe37a5380ee9088f7ace2efcde9"
}

Proposed format:

{
    "Description": {
       "name": "X Bytes"
       "order": 0
    }
    "PreImage": "68656c6c6f20776f726c64",
    "Hash":     "b94d27b9934d3e08a52e52d7da7dabfac484efe37a5380ee9088f7ace2efcde9"
}

@tumberger wdyt?

@StefanosChaliasos StefanosChaliasos self-assigned this Mar 9, 2023
@colinsteidtmann
Copy link

I like this idea!

@StefanosChaliasos
Copy link
Collaborator Author

You can work on that if you want to. This one does not need much explanation. The TODO list will include the following:

  • Decide on the specific format (I guess the above should be ok-ish)
  • Update existing configs
  • Update processing scripts (I don't think they actually need to be updated, but you should check that everything works).
  • Update the UI code to process and display the descriptions
  • Re-run experiments to get new logs and push them only (that can be done by me or @tumberger).

@StefanosChaliasos StefanosChaliasos added this to the v0.1.0 milestone May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants