Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circom/snarkjs TODOs #1

Closed
4 of 6 tasks
StefanosChaliasos opened this issue Feb 19, 2023 · 2 comments
Closed
4 of 6 tasks

Circom/snarkjs TODOs #1

StefanosChaliasos opened this issue Feb 19, 2023 · 2 comments
Milestone

Comments

@StefanosChaliasos
Copy link
Collaborator

StefanosChaliasos commented Feb 19, 2023

  • Currently, we are benchmarking circom/snarkjs, using the time command. This way, the comparison is not equal to libraries as we have the nodejs overhead. However, this will most probably be negligible for large benchmarks.
  • Add PLONK and FFLONK support
  • Add support for C++ witness generation. In this case, should we also include the time for complying with the cpp code in the logs?
  • Cores/Thread: Node uses one single thread in one core. Nevertheless, snarkjs (and the underlying library ffjavascript) use workers to perform operations; hence it isn't actually single-threaded. We could instrument snarkjs so it uses only a single worker. -- We decided yo use best available options
  • Add proof size
  • Use rapidsnark
@StefanosChaliasos
Copy link
Collaborator Author

We could potentially run circom and snarkjs through a node script directly

@tumberger tumberger added this to the v0.1.0 milestone Apr 15, 2023
@StefanosChaliasos
Copy link
Collaborator Author

#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants