Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much verbosity #15

Open
nachog00 opened this issue Jan 5, 2025 · 2 comments
Open

Too much verbosity #15

nachog00 opened this issue Jan 5, 2025 · 2 comments

Comments

@nachog00
Copy link
Contributor

nachog00 commented Jan 5, 2025

I noticed that logs by tracing are spitting the whole app before logging the intended message.
I haven't pinpointed where that behavior comes from (might be tracing's default?).
It seems a bit cluttering to me, but I wouldn't block this PR on that anyways.

@ala-mode Do you agree on changing that or is there any big pro of having it that way that I'm missing? Maybe we would like to cap it to DEBUG level logs only?

Originally posted by @nachog00 in #13 (review)

@nachog00
Copy link
Contributor Author

nachog00 commented Jan 5, 2025

Here's an example of this behaviour (ae459c48eaba1dfb6c98db8da254aecf6eda9a80)

> cargo run
...
2025-01-05T20:43:09.762778Z  INFO binary_dealer: set https_port to : 3953
2025-01-05T20:43:09.762883Z  INFO binary_dealer: set app as : Router { path_router: PathRouter { routes: {RouteId(1): Route
(Route), RouteId(2): Route(Route), RouteId(3): Route(Route)}, node: Node { paths: {RouteId(2): "/getme", RouteId(1): "/getm
e/*__private__axum_nest_tail_param", RouteId(3): "/getme/"} } }, fallback_router: PathRouter { routes: {RouteId(2): Route(R
oute), RouteId(1): Route(Route)}, node: Node { paths: {RouteId(1): "/", RouteId(2): "/*__private__axum_fallback"} } }, defa
ult_fallback: true, catch_all_fallback: Default(Route) }
2025-01-05T20:43:09.762934Z DEBUG binary_dealer serve function{app=Router { path_router: PathRouter { routes: {RouteId(1):
Route(Route), RouteId(2): Route(Route), RouteId(3): Route(Route)}, node: Node { paths: {RouteId(2): "/getme", RouteId(1): "
/getme/*__private__axum_nest_tail_param", RouteId(3): "/getme/"} } }, fallback_router: PathRouter { routes: {RouteId(2): Ro
ute(Route), RouteId(1): Route(Route)}, node: Node { paths: {RouteId(1): "/", RouteId(2): "/*__private__axum_fallback"} } },
 default_fallback: true, catch_all_fallback: Default(Route) } https_port=3953}: binary_dealer: serve function launched!
2025-01-05T20:43:09.762948Z  INFO binary_dealer serve function{app=Router { path_router: PathRouter { routes: {RouteId(1):
Route(Route), RouteId(2): Route(Route), RouteId(3): Route(Route)}, node: Node { paths: {RouteId(2): "/getme", RouteId(1): "
/getme/*__private__axum_nest_tail_param", RouteId(3): "/getme/"} } }, fallback_router: PathRouter { routes: {RouteId(2): Ro
ute(Route), RouteId(1): Route(Route)}, node: Node { paths: {RouteId(1): "/", RouteId(2): "/*__private__axum_fallback"} } },
 default_fallback: true, catch_all_fallback: Default(Route) } https_port=3953}: binary_dealer: 127.0.0.1:3953 address set!
2025-01-05T20:43:09.765277Z  INFO binary_dealer serve function{app=Router { path_router: PathRouter { routes: {RouteId(1):
Route(Route), RouteId(2): Route(Route), RouteId(3): Route(Route)}, node: Node { paths: {RouteId(2): "/getme", RouteId(1): "
/getme/*__private__axum_nest_tail_param", RouteId(3): "/getme/"} } }, fallback_router: PathRouter { routes: {RouteId(2): Ro
ute(Route), RouteId(1): Route(Route)}, node: Node { paths: {RouteId(1): "/", RouteId(2): "/*__private__axum_fallback"} } },
 default_fallback: true, catch_all_fallback: Default(Route) } https_port=3953}: binary_dealer: Initialized config: RustlsCo
nfig

@ala-mode
Copy link
Collaborator

ala-mode commented Jan 5, 2025

Yes, I agree, if we could get a better handle on these tracing logs that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants