Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should Run the Language Server over Slice Files Outside Configuration Sets #37

Open
InsertCreativityHere opened this issue Jan 23, 2024 · 0 comments
Labels

Comments

@InsertCreativityHere
Copy link
Member

Currently, if the user has any configuration sets... configured, we only compile files within those sets.
So if there are any files outside the sets, we completely ignore them.

This may be unintuitive to users, and limits the reach of the language server.


Instead, I propose that we always run the language server over every Slice file.
If a file is inside a configuration set, we compile the entire set, as we already do.
If we find a file not in a configuration set, I think we should still compile it, but as a stand-alone compilation.

But, this may give false diagnostics, ie. They using FooBar which is defined, but isn't found because we're doing a stand-alone compilation.

I see 2 ways to fix this, which are not mutually exclusive:

  • When we find a file outside a set, we issue a little popup saying it's not in a set (this is what Rust does)
  • We filter the errors, and only let certain errors through (syntax, bad attributes, etc.) errors that don't depend on other files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant