Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta cannot detect light/dark theme from within terminal #20761

Closed
1 task done
samhh opened this issue Nov 16, 2024 · 2 comments
Closed
1 task done

Delta cannot detect light/dark theme from within terminal #20761

samhh opened this issue Nov 16, 2024 · 2 comments
Labels
bug [core label] terminal Feedback for terminal integration, shell commands, etc theme Feedback for theme configuration, accessibility, visual issues, etc unactionable

Comments

@samhh
Copy link

samhh commented Nov 16, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Using Zed's built-in terminal with Delta configured as the pager for something like Git, it's unable to detect light mode. This is in contrast to running the same command (e.g. git show) in Kitty.

Delta can be forced into light mode by configuring it with --light, which exposes how it should look when Zed is in light mode.

Here's Delta's change: dandavison/delta#1615
And here's Lazygit for example fixing compatibility: jesseduffield/lazygit#3419

Environment

Zed stable 0.161.2, macOS 15.1

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

@samhh samhh added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 16, 2024
@notpeter
Copy link
Member

notpeter commented Nov 18, 2024

Can you provide explicit steps to reproduce?
What is the behavior you were expecting / what actually happened?

Here's what I did:

brew install delta
echo -e "FOO=BAR\nBAR=BAZ\n\MOP=POP\n" > a.env
echo -e "FOO=BAR\nBAR=BOP\n\MOP=POP\n" > b.env
delta a.env b.env

One Light
Screenshot 2024-11-18 at 17 50 30

One Dark
Screenshot 2024-11-18 at 17 50 57

And this looks, um fine?

@notpeter notpeter added terminal Feedback for terminal integration, shell commands, etc needs info / awaiting response Issue that needs more information from the user theme Feedback for theme configuration, accessibility, visual issues, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 18, 2024
@samhh
Copy link
Author

samhh commented Nov 19, 2024

It works now 🤷 Thanks for taking a look.

@samhh samhh closed this as completed Nov 19, 2024
@notpeter notpeter added unactionable and removed needs info / awaiting response Issue that needs more information from the user labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] terminal Feedback for terminal integration, shell commands, etc theme Feedback for theme configuration, accessibility, visual issues, etc unactionable
Projects
None yet
Development

No branches or pull requests

2 participants