Undo/Redo not jumping to what was undid or redone

[zambetti]

When I undo/redo, sometimes (I don't know why) the buffers don't jump to the line to show me what was undid or redone.

Weirdly, if I have the same file open in different buffers, it seems like they each will jump differently when I undo/redo. Perhaps they will jump if that is the buffer that that particular change was performed in?

Undo/redo should always be shown somehow; to perform changes without displaying them, is unnerving.

Likely related to this, the menubar options Edit > Undo, and Edit > Redo are sometimes grayed-out (indicating that there is nothing to undo/redo), but in fact, when you use the key commands, undos/redos are performed.

Has anyone else encountered these oddities with undo/redo?

[maxbrunsfeld]

Thanks for bringing this up. I wrote a bug report this with reproduction steps. https://github.com/zed-industries/community/issues/2061, for the scrolling issue that you described.

[zambetti]

Thank you Max. From a UI perspective, two solutions come to mind to solve this.

1. Show the undo/redo in whichever currently-visible pane is nearest to the relevant line. This would best preserve the scroll-positions in split-editing scenarios (where the same file is open in two panes simultaneously at different scroll-positions). However, it could be disorienting to see multiple buffers jumping scroll-position on undo/redo.

2. Only jump in the pane that is currently focused. This would likely be easiest to implement, and should feel familiar since this is how most editors work. However, in the split-editing scenario, the scroll-position is lost due to the undo-redo jump.

Both of these solutions would handle the case where changes were made in a pane that was later closed. They would also both avoid non-visible pane tabs popping into focus unexpectedly just to show undos/redos.

Considering that with all the navigation features it's pretty easy to return to where you were; #2 might be best since it's most familiar.

[viniciusnevescosta]

I wanted to share a very stressful situation. I just lost an entire file of code because I right clicked on another file name. For some reason the editor selects 2 files (the one I was editing and the one I selected), and this behavior doesn't make sense, if I wanted to select 2 files I would have simply pressed shift or cmd and then clicked on the files. I ended up losing an empty file that I wanted and what I was editing. I'm sorry, but this should be a basic function of an IDE.