Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Let highlight and action trigger as a filter #278

Open
keai4le opened this issue Mar 10, 2023 · 5 comments
Open

[Feature] Let highlight and action trigger as a filter #278

keai4le opened this issue Mar 10, 2023 · 5 comments
Labels
enhancement this will make things better Feature what a great idea

Comments

@keai4le
Copy link

keai4le commented Mar 10, 2023

Feature

I have a use case:
When I enable a highlight and action trigger, I'd like the highlighting lines to show at filtered view.

Is that possible to realization?

@Hirogen
Copy link
Collaborator

Hirogen commented Mar 10, 2023

Do you mean, you want the highlights and triggers also be active in the filter view?

@keai4le
Copy link
Author

keai4le commented Mar 10, 2023

Do you mean, you want the highlights and triggers also be active in the filter view?

Dear Hirogen,

I'd like the highlight words also be filtered at the same time, maybe let it as a option(checkbox).

e.g.
I have a trigger for two words: "foo", "bar"

And there's a log file, it's content:

03-09 17:36:12.303 2377 2988 I xxxx: line1
03-09 17:36:12.303 1396 3263 D foo: line2
03-09 17:36:12.303 1396 3263 D bar: line3
03-09 17:36:12.303 1396 3263 D ddddd: line4
03-09 17:36:12.303 2377 2988 I ssss: foo, bar line5

when I enable the trigger, I want those 3 lines in filtered view automatically
03-09 17:36:12.303 1396 3263 D foo: line2
03-09 17:36:12.303 1396 3263 D bar: line3
03-09 17:36:12.303 2377 2988 I ssss: foo, bar line5

@Hirogen
Copy link
Collaborator

Hirogen commented Mar 10, 2023

The filter should support regex, could you give it a try, if that fits your needs?

Maybe I do not yet understand your requirement :)

@keai4le
Copy link
Author

keai4le commented Mar 13, 2023

The filter should support regex, could you give it a try, if that fits your needs?

Maybe I do not yet understand your requirement :)

Sure, the filter support regex.
But we have to enable the trigger and fill the filter field then click "search" in my use case.
And I have to save the regrex string at 2 places:
image
image

Now, I want to merge all work flow into: "enable the trigger" and all things done. :)

@Hirogen
Copy link
Collaborator

Hirogen commented Mar 20, 2023

Ah I understand, you want the text filter to have all the highlight and trigger actions as a selectable text

Not sure if that is feasible, but those are actually two different features, that probably should not be combined.

The Filter-Dialog needs a major rework for UI and dropdown selection, so the user knows which texts are highlights and which are not.

The filter texts are saved across sessions, you can change the amount of saved filters in the settings
image

@Hirogen Hirogen added enhancement this will make things better Feature what a great idea labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this will make things better Feature what a great idea
Projects
None yet
Development

No branches or pull requests

2 participants