Should we remove no-await-in-loop rule ?

[tpoisseau]

https://github.com/zakodium/profid/pull/1910#discussion_r1799472129

I agree ideally we should parallelize async statements but often we disable this rule many times in a for loop, or on the file, on purpose.
To reduce workload, to simplify error management / avoid racing conditions.

I don't have memories where the rules reminds me I should Promise.all / Promise.allSettled instead of await in sequence.

It's not the first time we talk about this rule in an issue, or in vocal.

So, what do we do ?

@zakodium/collaborators

[stropitek]

I think we can disabled it by default, and enable it in specific parts of an application or files where we know we have to be extra mindful about this.

[Sebastien-Ahkrin]

I agree with your proposal Daniel

[targos]

I agree too.

[lpatiny]

Thanks to this rule, we significantly improved the loading of files (fetch in parallel) in NMRium. Of course, we could optionally enable it, but I think it will be easier to optionally disable it for a full project.