Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 support #15

Open
immomp opened this issue Jun 15, 2022 · 1 comment
Open

Python 3.7 support #15

immomp opened this issue Jun 15, 2022 · 1 comment

Comments

@immomp
Copy link

immomp commented Jun 15, 2022

Hi,

the documentation states that you support Python 3.7 but it appears that you use the walrus operator, for example here:

if akey := request.GET.get(ad_key):

This breaks 3.7 support, I think.

Thank you!
(also for a great app)

@hugorodgerbrown
Copy link
Collaborator

Hi @immomp - that's correct, thanks for pointing this out. I will update the docs and the classifiers, and tag the last commit that supports Python 3.7, but I won't update the main branch to remove the := as we an deliberate "forward-only and deprecate" policy - as new syntax comes in we adopt early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants