Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPIRL: Redundant Constraints #4

Open
aaronsnoswell opened this issue Apr 4, 2018 · 1 comment
Open

LPIRL: Redundant Constraints #4

aaronsnoswell opened this issue Apr 4, 2018 · 1 comment

Comments

@aaronsnoswell
Copy link

Hi! Thank you for this great reference implementation - it is very helpful.

I was going over the LPIRL implementation and I think you have some redundant constraints in your LP matrices - see line 59 in lp_irl.py - this loop does the same thing as the previous loop on line 55, resulting in a redundant set of constraints.

Thanks again,

@MithunNallana
Copy link

@aaronsnoswell

Yeah. I too think the same way. In line 60, It should be -1.0 instead of 1.0.
If I am correct, constraint in line 55 and line 59 should provide constraints that proxy l1 norm. Can you please check this @yrlu .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants