You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thank you for this great reference implementation - it is very helpful.
I was going over the LPIRL implementation and I think you have some redundant constraints in your LP matrices - see line 59 in lp_irl.py - this loop does the same thing as the previous loop on line 55, resulting in a redundant set of constraints.
Thanks again,
The text was updated successfully, but these errors were encountered:
Yeah. I too think the same way. In line 60, It should be -1.0 instead of 1.0.
If I am correct, constraint in line 55 and line 59 should provide constraints that proxy l1 norm. Can you please check this @yrlu .
Hi! Thank you for this great reference implementation - it is very helpful.
I was going over the LPIRL implementation and I think you have some redundant constraints in your LP matrices - see line 59 in lp_irl.py - this loop does the same thing as the previous loop on line 55, resulting in a redundant set of constraints.
Thanks again,
The text was updated successfully, but these errors were encountered: