Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in share.html have the incorrect class name #104

Open
AlexBurkey opened this issue Jun 17, 2020 · 3 comments
Open

Icons in share.html have the incorrect class name #104

AlexBurkey opened this issue Jun 17, 2020 · 3 comments

Comments

@AlexBurkey
Copy link

Icons in the footer/share section of posts don't have the correct class for the i-frame. All of the "Brands" (Facebook, Twitter, G+, etc.) need to be prefixed with fab and the "Share" icon needs to be prefixed with fa

Example:
<i class="fa-facebook" aria-hidden="true"></i>
<i class="fab fa-facebook" aria-hidden="true"></i>

image

image
@AlexBurkey
Copy link
Author

Existing PR to fix: #101

@Tristor Tristor mentioned this issue Feb 7, 2021
Merged
@Tristor
Copy link
Contributor

Tristor commented Feb 7, 2021

This is fixed in #110 which has been merged.

@dwy6626
Copy link
Contributor

dwy6626 commented Aug 6, 2021

@AlexBurkey maybe you can check this issue again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tristor @AlexBurkey @dwy6626