Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new maintainers #96

Open
Revisor opened this issue Nov 27, 2015 · 9 comments
Open

Add new maintainers #96

Revisor opened this issue Nov 27, 2015 · 9 comments
Labels

Comments

@Revisor
Copy link

Revisor commented Nov 27, 2015

It's a nice and useful library, but it needs more care - solve outstanding issues, tag release versions regularly.

If you don't have the time or willpower to work on it, add more maintainers. Please don't let it die.

@ksn135
Copy link
Contributor

ksn135 commented Nov 27, 2015

👍

@RonRademaker
Copy link
Contributor

Anyone who (like me) likes the 1.0 branch better than where master was heading is welcome to join me on https://github.com/RonRademaker/Finite, I'll actively maintain this 1.0 fork and use semver for new releases.

@phillipsnick
Copy link

@RonRademaker haven't looked too much into master vs 1.0, what were the major changes?

@tortuetorche
Copy link
Contributor

@RonRademaker I'm happy with the master branch for both my Laravel 4.2 and 5.1 applications.

@RonRademaker
Copy link
Contributor

@phillipsnick basically the StatefulInterface has been replaced by a StateAccessor that by default uses a public variable state. It's more like the winzou/statemachine I think. I started using and went back to 1.0 fast (it's a matter of taste of course).

@Revisor
Copy link
Author

Revisor commented Nov 27, 2015

My preferred solution would be for @yohang to add more maintainers to this repo. This is a known quantity, it has articles written about it, two weeks ago someone mentioned it by the way at a conference - it has the most attention in bug hunting and issues.

If that doesn't work, a fork would also be a solution, but forks always have to start from the scratch regarding visibility which might be a disadvantage.

@yohang
Copy link
Owner

yohang commented Nov 27, 2015

Hi,

I tweeted about adding new maintainers few weeks ago, I agree, send me a mail if interested.

And I'll have some time for updates very soon.

@Revisor
Copy link
Author

Revisor commented Nov 27, 2015

Thanks, Yohan, we use the library, love it and would like to help. We'll send an email to you.

@tortuetorche
Copy link
Contributor

Hi @yohang,

Can you add me as a contributor, please?
To refresh your mind, I'm the author of Finite State Machine and Finite Audit Trail traits for Laravel.

I'll not be a big contributor, but I can send fix, from time to time.

Cheers,
Tortue Torche

@yohang yohang added the future label Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants