-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a version with dune support #66
Comments
unfortunately it seems there are new issues that need to be resolved first - lwt and lwt_ppx is marked as depopt but build actually fails when lwt_ppx is missing |
@kit-ty-kate: can you assist on what is the standard way to layout packages which have parts with optional dependencies which should only be installed if the dependencies are present? Thanks! |
As a personal advice i would implore people to avoid optional subpackages as they're simply more annoying for users, lint/build tools makers and opam-repository maintainers alike. That said, as for the issue at hand I'm not sure to see where lwt_ppx is actually used. I'm only seeing it in the |
I just noticed that you're using OCaml-CI. By deduction I'm guessing the "failure" mentioned above are from there. OCaml-CI cannot be used for this repository anyway as it requires the out-of-the-box |
one example uses lwt_ppx which we don't want to depend on, see #66 examples that are part of the tests are built alright during make test
Hi! I'd like to vendor ocurl in a project that builds with dune. I noticed that ocurl recently got dune support, but it hasn't been released since then. Can you please do a release that includes the dune support.
The text was updated successfully, but these errors were encountered: