Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a version with dune support #66

Open
gridbugs opened this issue Jan 5, 2023 · 4 comments
Open

Publish a version with dune support #66

gridbugs opened this issue Jan 5, 2023 · 4 comments

Comments

@gridbugs
Copy link

gridbugs commented Jan 5, 2023

Hi! I'd like to vendor ocurl in a project that builds with dune. I noticed that ocurl recently got dune support, but it hasn't been released since then. Can you please do a release that includes the dune support.

@ygrek
Copy link
Owner

ygrek commented Jan 27, 2023

unfortunately it seems there are new issues that need to be resolved first - lwt and lwt_ppx is marked as depopt but build actually fails when lwt_ppx is missing

@nojb
Copy link
Contributor

nojb commented Jan 27, 2023

@kit-ty-kate: can you assist on what is the standard way to layout packages which have parts with optional dependencies which should only be installed if the dependencies are present? Thanks!

@kit-ty-kate
Copy link
Contributor

As a personal advice i would implore people to avoid optional subpackages as they're simply more annoying for users, lint/build tools makers and opam-repository maintainers alike.

That said, as for the issue at hand I'm not sure to see where lwt_ppx is actually used. I'm only seeing it in the examples directory where it is used to build an executable that isn't installed or tested using opam (it's only used when calling dune build with any arguments by hand). So the depopt towards lwt_ppx should just be removed and there shouldn't be any problem.

@kit-ty-kate
Copy link
Contributor

I just noticed that you're using OCaml-CI. By deduction I'm guessing the "failure" mentioned above are from there.

OCaml-CI cannot be used for this repository anyway as it requires the out-of-the-box dune build to work and the current setup this repository has requires calling the ./configure script first to generate the required dune-project file for some reason.

ygrek added a commit that referenced this issue Jul 15, 2024
one example uses lwt_ppx which we don't want to depend on, see #66
examples that are part of the tests are built alright during make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants