Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example static files are ignored by the build.sh script #1331

Closed
jstarry opened this issue Jun 20, 2020 · 3 comments · Fixed by #1417
Closed

Example static files are ignored by the build.sh script #1331

jstarry opened this issue Jun 20, 2020 · 3 comments · Fixed by #1417
Labels
A-examples Area: The examples bug

Comments

@jstarry
Copy link
Member

jstarry commented Jun 20, 2020

Problem
We have a nice script for building examples now but it puts all generated wasm / js in the examples/static folder. This means that any static files for specific examples are ignored.

Proposed Change

  • Remove examples/static
  • Modify examples/build.sh to generate files in the example's static folder
@jstarry jstarry added bug A-examples Area: The examples labels Jun 20, 2020
@jstarry
Copy link
Member Author

jstarry commented Jun 20, 2020

@numerodix would you be interested in picking up this task? It's related to #1289

@numerodix
Copy link
Contributor

Thanks for thinking of me, @jstarry :)
This is something I was thinking of doing as part of #1289. Why don't I get started on that one then. :)

@jstarry
Copy link
Member Author

jstarry commented Jun 21, 2020

No problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants