Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing to upstream #5

Open
ShaMan123 opened this issue Jul 27, 2022 · 1 comment
Open

contributing to upstream #5

ShaMan123 opened this issue Jul 27, 2022 · 1 comment

Comments

@ShaMan123
Copy link

Hi @yassilah
Cool extensions, I'll definitely give it a go.
I think text vertical align is totally something that can be ported to fabric (perhaps after TS)
And I wanted you to take a look at the draggable text PRs fabricjs/fabric.js#7802 fabricjs/fabric.js#8065, since you implemented dnd as an extension.
@yassilah
Copy link
Owner

Hi! I was just on vacation but thanks a lot for your feedback, and I'd be happy to take a look at those PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yassilah @ShaMan123